Page MenuHomePhabricator

Remove "Show All Context" button from Diffusion
ClosedPublic

Authored by epriestley on May 8 2017, 5:06 PM.
Tags
None
Referenced Files
F19938252: D17843.diff
Tue, Apr 14, 12:36 AM
F19830367: D17843.diff
Mar 10 2026, 12:44 PM
F19809788: D17843.id43046.diff
Mar 3 2026, 3:06 PM
F19790030: D17843.diff
Feb 25 2026, 6:52 PM
F19672325: D17843.id42922.diff
Feb 8 2026, 3:13 AM
F19671915: D17843.id.diff
Feb 8 2026, 2:03 AM
F19561097: D17843.id43046.diff
Jan 31 2026, 9:11 AM
F18932977: D17843.id42922.diff
Nov 10 2025, 9:51 AM
Subscribers
None

Details

Summary

Ref T12616. Diffusion, only, has a "Show All Context" button which expands the full context on all changes.

I don't remember the exact history on this, but it hasn't existed in Differential for some time and no one has complained. I suspect that the "View Options > Show All Context" on each file may replace it. I can't really come up with good reasons to use it, offhand. If we want to restore it, I think global options after T1591 is promising.

Screen Shot 2017-05-08 at 9.58.04 AM.png (309×425 px, 33 KB)

Test Plan
  • Loaded a commit in Diffusion, no longer saw a button.
  • Grepped for relevant sigils.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 9 2017, 2:41 AM
This revision was automatically updated to reflect the committed changes.