Page MenuHomePhabricator

Remove "Show All Context" button from Diffusion
ClosedPublic

Authored by epriestley on May 8 2017, 5:06 PM.
Tags
None
Referenced Files
F18932977: D17843.id42922.diff
Mon, Nov 10, 9:51 AM
F18871854: D17843.id43046.diff
Wed, Nov 5, 12:54 AM
F18851126: D17843.id.diff
Thu, Oct 30, 10:25 PM
F18847488: D17843.diff
Thu, Oct 30, 12:50 AM
F18775647: D17843.diff
Oct 10 2025, 7:42 PM
F18701255: D17843.diff
Sep 27 2025, 6:05 PM
F18670810: D17843.id.diff
Sep 25 2025, 1:39 AM
F18595762: D17843.diff
Sep 12 2025, 10:48 PM
Subscribers
None

Details

Summary

Ref T12616. Diffusion, only, has a "Show All Context" button which expands the full context on all changes.

I don't remember the exact history on this, but it hasn't existed in Differential for some time and no one has complained. I suspect that the "View Options > Show All Context" on each file may replace it. I can't really come up with good reasons to use it, offhand. If we want to restore it, I think global options after T1591 is promising.

Screen Shot 2017-05-08 at 9.58.04 AM.png (309×425 px, 33 KB)

Test Plan
  • Loaded a commit in Diffusion, no longer saw a button.
  • Grepped for relevant sigils.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 9 2017, 2:41 AM
This revision was automatically updated to reflect the committed changes.