Page MenuHomePhabricator

Remove "Show All Context" button from Diffusion
ClosedPublic

Authored by epriestley on May 8 2017, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 5:27 PM
Unknown Object (File)
Thu, Dec 19, 5:27 PM
Unknown Object (File)
Tue, Dec 17, 9:33 PM
Unknown Object (File)
Mon, Dec 16, 5:49 PM
Unknown Object (File)
Mon, Dec 16, 9:27 AM
Unknown Object (File)
Fri, Dec 13, 11:47 AM
Unknown Object (File)
Mon, Dec 9, 12:03 AM
Unknown Object (File)
Thu, Dec 5, 7:53 PM
Subscribers
None

Details

Summary

Ref T12616. Diffusion, only, has a "Show All Context" button which expands the full context on all changes.

I don't remember the exact history on this, but it hasn't existed in Differential for some time and no one has complained. I suspect that the "View Options > Show All Context" on each file may replace it. I can't really come up with good reasons to use it, offhand. If we want to restore it, I think global options after T1591 is promising.

Screen Shot 2017-05-08 at 9.58.04 AM.png (309×425 px, 33 KB)

Test Plan
  • Loaded a commit in Diffusion, no longer saw a button.
  • Grepped for relevant sigils.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 9 2017, 2:41 AM
This revision was automatically updated to reflect the committed changes.