HomePhabricator

Modularize content sources

Description

Modularize content sources

Summary:
Ref T10537. For Nuance, I want to introduce new sources (like "GitHub" or "GitHub via Nuance" or something) but this needs to modularize eventually.

Split ContentSource apart so applications can add new content sources.

Test Plan:
This change has huge surface area, so I'll hold it until post-release. I think it's fairly safe (and if it does break anything, the breaks should be fatals, not anything subtle or difficult to fix), there's just no reason not to hold it for a few hours.

  • Viewed new module page.
  • Grepped for all removed functions/constants.
  • Viewed some transactions.
  • Hovered over timestamps to get content source details.
  • Added a comment via Conduit.
  • Added a comment via web.
  • Ran bin/storage upgrade --namespace XXXXX --no-quickstart -f to re-run all historic migrations.
  • Generated some objects with bin/lipsum.
  • Ran a bulk job on some tasks.
  • Ran unit tests.

Screen Shot 2016-03-25 at 6.42.23 AM.png (1×1 px, 249 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10537

Differential Revision: https://secure.phabricator.com/D15521

Details

Provenance
epriestleyAuthored on Mar 25 2016, 12:56 PM
epriestleyPushed on Mar 26 2016, 6:59 PM
Reviewer
chad
Differential Revision
D15521: Modularize content sources
Parents
rPd784d9c0440c: Set blue background (unless it looks terrible)
Branches
Unknown
Tags
Unknown
Tasks
T10537: Nuance Infrastructure
Build Status
Buildable 11297
Build 14047: Run Core Tests