Page MenuHomePhabricator

Modularize content sources
ClosedPublic

Authored by epriestley on Mar 25 2016, 1:51 PM.
Tags
None
Referenced Files
F15545274: D15521.id.diff
Sat, Apr 26, 9:52 AM
F15540056: D15521.diff
Fri, Apr 25, 6:28 AM
F15533775: D15521.diff
Wed, Apr 23, 9:59 PM
F15484391: D15521.diff
Wed, Apr 9, 6:03 PM
F15450821: D15521.id37433.diff
Mar 28 2025, 6:25 PM
F15440009: D15521.id.diff
Mar 26 2025, 10:42 AM
F15435052: D15521.diff
Mar 25 2025, 6:39 AM
F15388547: D15521.id37417.diff
Mar 15 2025, 3:59 AM
Subscribers
None

Details

Summary

Ref T10537. For Nuance, I want to introduce new sources (like "GitHub" or "GitHub via Nuance" or something) but this needs to modularize eventually.

Split ContentSource apart so applications can add new content sources.

Test Plan

This change has huge surface area, so I'll hold it until post-release. I think it's fairly safe (and if it does break anything, the breaks should be fatals, not anything subtle or difficult to fix), there's just no reason not to hold it for a few hours.

  • Viewed new module page.
  • Grepped for all removed functions/constants.
  • Viewed some transactions.
  • Hovered over timestamps to get content source details.
  • Added a comment via Conduit.
  • Added a comment via web.
  • Ran bin/storage upgrade --namespace XXXXX --no-quickstart -f to re-run all historic migrations.
  • Generated some objects with bin/lipsum.
  • Ran a bulk job on some tasks.
  • Ran unit tests.

Screen Shot 2016-03-25 at 6.42.23 AM.png (1×1 px, 249 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize content sources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2016, 10:50 PM
This revision was automatically updated to reflect the committed changes.