HomePhabricator

Fix an issue where repository message counts would never reset

Description

Fix an issue where repository message counts would never reset

Summary:
Fixes T11705. I did not realize that ON DUPLICATE KEY UPDATE was order-dependent, so the "reset" clause of this IF(...) never actually worked.

Reorder it so we check if we're changing the message type first, then actually change the message type.

This makes the count reset properly when a failing repository succeeds, or a working repository fails.

Test Plan:

  • On master, forced a working repository to fail a bin/repository update, saw the message change types (expected) but keep the old count (wrong!).
  • With this patch, repeated the process and saw the count reset properly.
  • Ran the patch, verified counts reset to 0.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11705

Differential Revision: https://secure.phabricator.com/D16623

Details

Provenance
epriestleyAuthored on Sep 28 2016, 9:49 PM
epriestleyPushed on Sep 28 2016, 10:02 PM
Reviewer
chad
Differential Revision
D16623: Fix an issue where repository message counts would never reset
Parents
rP360597d8eea5: Link user name in People log view to user page
Branches
Unknown
Tags
Unknown
Tasks
T11705: Repositories are getting stuck
Build Status
Buildable 13908
Build 18004: Run Core Tests