Paths

Table of Contentst

Differential D16623

Fix an issue where repository message counts would never reset
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 9:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 18, 11:48 AM

	Unknown Object (File)
	Sun, Feb 9, 2:29 AM

	Unknown Object (File)
	Sun, Feb 9, 2:29 AM

	Unknown Object (File)
	Sun, Feb 9, 2:29 AM

	Unknown Object (File)
	Sat, Jan 25, 3:45 PM

	Unknown Object (File)
	Fri, Jan 24, 4:35 PM

	Unknown Object (File)
	Fri, Jan 24, 4:34 PM

	Unknown Object (File)
	Fri, Jan 24, 4:34 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11705: Repositories are getting stuck

Commits

rP921aab604ec7: (stable) Fix an issue where repository message counts would never reset
rP5d1359d78f66: Fix an issue where repository message counts would never reset

Summary

Fixes T11705. I did not realize that ON DUPLICATE KEY UPDATE was order-dependent, so the "reset" clause of this IF(...) never actually worked.

Reorder it so we check if we're changing the message type first, then actually change the message type.

This makes the count reset properly when a failing repository succeeds, or a working repository fails.

Test Plan

On master, forced a working repository to fail a bin/repository update, saw the message change types (expected) but keep the old count (wrong!).
With this patch, repeated the process and saw the count reset properly.
Ran the patch, verified counts reset to 0.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40019.Sep 28 2016, 9:55 PM

epriestley retitled this revision from to Fix an issue where repository message counts would never reset.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11705: Repositories are getting stuck.

chad accepted this revision.Sep 28 2016, 10:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 10:02 PM

Closed by commit rP5d1359d78f66: Fix an issue where repository message counts would never reset (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 10:02 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11753: Diffusion update frequency gets large on update error.Oct 12 2016, 12:44 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160928.repo.messagecount.sql

4 lines

src/

applications/

repository/

storage/

PhabricatorRepository.php

18 lines

Diff 40020

resources/sql/autopatches/20160928.repo.messagecount.sql

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...