Page MenuHomePhabricator

Move misplaced validation for ambiguous fields in "Test Plan" to the right place
ClosedPublic

Authored by epriestley on Jun 30 2017, 1:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 8:46 PM
Unknown Object (File)
Feb 25 2024, 2:37 PM
Unknown Object (File)
Feb 16 2024, 6:06 PM
Unknown Object (File)
Feb 14 2024, 8:15 PM
Unknown Object (File)
Feb 13 2024, 9:25 PM
Unknown Object (File)
Dec 21 2023, 10:27 AM
Unknown Object (File)
Nov 30 2023, 12:57 AM
Unknown Object (File)
Nov 15 2023, 11:06 AM
Subscribers
None

Details

Summary

When users use the web UI to enter text like "Reviewers: x" into the "Summary" or "Test Plan", we can end up with an ambiguous commit message.

Some time ago we added a warning about this to the "Summary" field, and attempted to add it to the "Test Plan" field, but it actually gets called from the wrong place.

Remove the code from the wrong place (no callers, not reachable) and put it in the right place.

This fixes an issue where users could edit a test plan from the web UI to add the text "Tests: ..." and cause ambiguities on a later "arc diff --edit".

Test Plan

Screen Shot 2017-06-30 at 6.24.30 AM.png (1×2 px, 330 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable