HomePhabricator

Correct an issue where the commit list could group commits by server time

Description

Correct an issue where the commit list could group commits by server time

Summary:
Commits in the list are grouped by the date they occurred in server time. This may not be the date they occurred in client time.

Use client time, not server time, to group commits.

Test Plan:

  • Set server timezone to "Asia/Famagusta".
  • Set client timezone to "America/Los_Angeles".
  • Viewed Phabricator repository history.

Here's what it looks like before the change:

Screen Shot 2017-06-02 at 4.45.03 AM.png (1×1 px, 239 KB)

Note that the headers of the first two groups both say "Yesterday".

This is because the first commits in each group occurred on June 1 and June 2, respectively, in Famagusta, but both occurred on June 1 in Los Angeles.

Here's what it looks like after the change:

Screen Shot 2017-06-02 at 4.47.41 AM.png (1×1 px, 239 KB)

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18067

Details

Provenance
epriestleyAuthored on Jun 2 2017, 11:47 AM
epriestleyPushed on Jun 2 2017, 3:39 PM
Reviewer
chad
Differential Revision
D18067: Correct an issue where the commit list could group commits by server time
Parents
rP335c3a7d12bd: In commit history list view, show all commits
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17369
Build 23283: Run Core Tests