Page MenuHomePhabricator

Correct an issue where the commit list could group commits by server time
ClosedPublic

Authored by epriestley on Jun 2 2017, 11:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 3:19 PM
Unknown Object (File)
Sat, Apr 13, 3:18 PM
Unknown Object (File)
Sat, Apr 13, 3:10 PM
Unknown Object (File)
Sat, Apr 13, 2:34 PM
Unknown Object (File)
Sat, Apr 13, 12:55 PM
Unknown Object (File)
Sat, Apr 13, 10:43 AM
Unknown Object (File)
Fri, Apr 12, 7:52 PM
Unknown Object (File)
Fri, Apr 12, 7:52 PM
Subscribers
None

Details

Summary

Commits in the list are grouped by the date they occurred in server time. This may not be the date they occurred in client time.

Use client time, not server time, to group commits.

Test Plan
  • Set server timezone to "Asia/Famagusta".
  • Set client timezone to "America/Los_Angeles".
  • Viewed Phabricator repository history.

Here's what it looks like before the change:

Screen Shot 2017-06-02 at 4.45.03 AM.png (1×1 px, 239 KB)

Note that the headers of the first two groups both say "Yesterday".

This is because the first commits in each group occurred on June 1 and June 2, respectively, in Famagusta, but both occurred on June 1 in Los Angeles.

Here's what it looks like after the change:

Screen Shot 2017-06-02 at 4.47.41 AM.png (1×1 px, 239 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/diffusion/view/DiffusionHistoryListView.php
26–29

(These variables were not used.)

This revision is now accepted and ready to land.Jun 2 2017, 1:41 PM
This revision was automatically updated to reflect the committed changes.