HomePhabricator

Don't issue a bazillion queries to load Differential object lists

Description

Don't issue a bazillion queries to load Differential object lists

Summary:
Ref T3496. Currently, we call loadAssets() on each revision table, which invokes a new revision query and a pile of subqueries.

Instead, add needFlags() and needDrafts() to RevisionQuery. Some day these could perhaps be more generic.

Test Plan:

  • Viewed home, differential, etc., no longer saw 9203809238 queries being run for no reason.
  • Drafts and flags still appear properly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3496

Differential Revision: https://secure.phabricator.com/D8277

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 19 2014, 1:57 AM
Reviewer
btrahan
Differential Revision
D8277: Don't issue a bazillion queries to load Differential object lists
Parents
rP65bc2b1ac53d: Implement "Pro" version of revision editor, with one field
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline