Page MenuHomePhabricator

Don't issue a bazillion queries to load Differential object lists
ClosedPublic

Authored by epriestley on Feb 19 2014, 1:35 AM.
Tags
None
Referenced Files
F13814974: D8277.id19696.diff
Thu, Sep 19, 7:46 AM
Unknown Object (File)
Fri, Aug 30, 8:55 AM
Unknown Object (File)
Sun, Aug 25, 2:06 PM
Unknown Object (File)
Sun, Aug 25, 12:48 PM
Unknown Object (File)
Sun, Aug 25, 10:55 AM
Unknown Object (File)
Aug 20 2024, 1:57 PM
Unknown Object (File)
Aug 19 2024, 7:46 AM
Unknown Object (File)
Aug 17 2024, 10:40 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by chad."Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP50ed42761ce9: Don't issue a bazillion queries to load Differential object lists
Summary

Ref T3496. Currently, we call loadAssets() on each revision table, which invokes a new revision query and a pile of subqueries.

Instead, add needFlags() and needDrafts() to RevisionQuery. Some day these could perhaps be more generic.

Test Plan
  • Viewed home, differential, etc., no longer saw 9203809238 queries being run for no reason.
  • Drafts and flags still appear properly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

awesometown

divided by

9203809238

equals

awesometown

well okay 9203809238 is more like 9 or something but that's still more than 0!!~