Page MenuHomePhabricator

Don't issue a bazillion queries to load Differential object lists
ClosedPublic

Authored by epriestley on Feb 19 2014, 1:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 6, 5:15 AM
Unknown Object (File)
Apr 4 2026, 8:24 PM
Unknown Object (File)
Mar 15 2026, 12:18 PM
Unknown Object (File)
Mar 8 2026, 5:53 PM
Unknown Object (File)
Mar 4 2026, 10:43 AM
Unknown Object (File)
Feb 6 2026, 9:30 AM
Unknown Object (File)
Jan 13 2026, 4:24 AM
Unknown Object (File)
Nov 29 2025, 8:26 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by chad."Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP50ed42761ce9: Don't issue a bazillion queries to load Differential object lists
Summary

Ref T3496. Currently, we call loadAssets() on each revision table, which invokes a new revision query and a pile of subqueries.

Instead, add needFlags() and needDrafts() to RevisionQuery. Some day these could perhaps be more generic.

Test Plan
  • Viewed home, differential, etc., no longer saw 9203809238 queries being run for no reason.
  • Drafts and flags still appear properly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

awesometown

divided by

9203809238

equals

awesometown

well okay 9203809238 is more like 9 or something but that's still more than 0!!~