Page MenuHomePhabricator

Don't issue a bazillion queries to load Differential object lists
ClosedPublic

Authored by epriestley on Feb 19 2014, 1:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 2, 1:48 AM
Unknown Object (File)
Sat, May 31, 8:19 PM
Unknown Object (File)
May 5 2025, 4:36 PM
Unknown Object (File)
Apr 14 2025, 8:16 AM
Unknown Object (File)
Apr 11 2025, 12:16 PM
Unknown Object (File)
Apr 7 2025, 8:27 PM
Unknown Object (File)
Apr 6 2025, 9:26 PM
Unknown Object (File)
Apr 5 2025, 7:42 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by chad."Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP50ed42761ce9: Don't issue a bazillion queries to load Differential object lists
Summary

Ref T3496. Currently, we call loadAssets() on each revision table, which invokes a new revision query and a pile of subqueries.

Instead, add needFlags() and needDrafts() to RevisionQuery. Some day these could perhaps be more generic.

Test Plan
  • Viewed home, differential, etc., no longer saw 9203809238 queries being run for no reason.
  • Drafts and flags still appear properly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

awesometown

divided by

9203809238

equals

awesometown

well okay 9203809238 is more like 9 or something but that's still more than 0!!~