Paths

Table of Contentst

Fix member edit transaction validation so it works for both implicit and…
505b1d8379a5
Actions

Description

Fix member edit transaction validation so it works for both implicit and explicit account creation

Summary:
Ref T12451. Ref T12484. This should deal with all the + / - / = cases correctly, I think.

Also makes sure that members are real users, not commits or tokens or whatever. And expands the creation test case to make some other basic sanity checks.

Test Plan:

Went through implicit first-time creation flow.
Went through explicit second-time creation flow.
Unit test now passes.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12484, T12451

Differential Revision: https://secure.phabricator.com/D17692

Details

Provenance

epriestley	Authored on Apr 14 2017, 4:54 PM
epriestley	Pushed on Apr 14 2017, 5:24 PM

Reviewer

chad

Differential Revision

D17692: Fix member edit transaction validation so it works for both implicit and explicit account creation

Parents

rP71d933d496ca: Add a failing test case for new Phortune account initialization

Branches

Unknown

Tags

Unknown

Tasks

T12451: Finding your subscriptions / cards on Phacility is non-obvious
T12484: Write some tests for Phortune

Build Status

Buildable 16483
Build 21948: Run Core Tests

Event Timeline

epriestley committed rP505b1d8379a5: Fix member edit transaction validation so it works for both implicit and… (authored by epriestley).Apr 14 2017, 5:24 PM

epriestley added a task: T12484: Write some tests for Phortune.

epriestley added a task: T12451: Finding your subscriptions / cards on Phacility is non-obvious.

Harbormaster completed building B16483: rP505b1d8379a5: Fix member edit transaction validation so it works for both implicit and….Apr 14 2017, 5:26 PM

Changes (2)

Path

Size

src/

applications/

phortune/

__tests__/

PhabricatorPhortuneTestCase.php

editor/

PhortuneAccountEditor.php

rP505b1d8379a5

View Options

src/applications/phortune/tests/PhabricatorPhortuneTestCase.php