Fix member edit transaction validation so it works for both implicit and explicit account creation
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:58 PM.

Details

Reviewers

chad

Maniphest Tasks

T12451: Finding your subscriptions / cards on Phacility is non-obvious
T12484: Write some tests for Phortune

Commits

rP505b1d8379a5: Fix member edit transaction validation so it works for both implicit and…

Summary

Ref T12451. Ref T12484. This should deal with all the + / - / = cases correctly, I think.

Also makes sure that members are real users, not commits or tokens or whatever. And expands the creation test case to make some other basic sanity checks.

Test Plan

Went through implicit first-time creation flow.
Went through explicit second-time creation flow.
Unit test now passes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2017, 4:58 PM

Harbormaster completed remote builds in B16477: Diff 42546.Apr 14 2017, 4:59 PM

chad accepted this revision.Apr 14 2017, 5:07 PM

This revision is now accepted and ready to land.Apr 14 2017, 5:07 PM

Closed by commit rP505b1d8379a5: Fix member edit transaction validation so it works for both implicit and… (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

__tests__/

PhabricatorPhortuneTestCase.php

17 lines

editor/

PhortuneAccountEditor.php

53 lines

Diff 42552

View Options

src/applications/phortune/tests/PhabricatorPhortuneTestCase.php

View Options

src/applications/phortune/editor/PhortuneAccountEditor.php

Fix member edit transaction validation so it works for both implicit and explicit account creationClosedPublicActions