Page MenuHomePhabricator

Don't store IP addresses in content sources
ClosedPublic

Authored by epriestley on Oct 21 2015, 7:36 PM.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP4afeebe83489: Don't store IP addresses in content sources
Summary

We don't use these for anything, we're inconsistent about recording them, and there's some mild interaction with privacy concerns and data retention. Every other log we store any kind of information in can be given a custom retention policy after recent GC changes.

If we did put this back eventually it would probably be better to store a session identifier anyway, since that's more granular and more detailed.

You can fetch this info out of access logs anyway, too.

Test Plan

Left a couple of comments.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Don't store IP addresses in content sources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 21 2015, 7:37 PM
This revision was automatically updated to reflect the committed changes.