Paths

Table of Contentst

Fix rendering of comments deleted by editing
ClosedPublic
Actions

Authored by epriestley on Mar 14 2014, 3:12 PM.

Tags

None

Referenced Files

	F14061486: D8533.diff
	Mon, Nov 18, 6:45 AM

	F14035875: D8533.id20242.diff
	Sun, Nov 10, 7:51 AM

	F14033147: D8533.diff
	Sat, Nov 9, 4:53 PM

	F14013421: D8533.id20242.diff
	Sat, Nov 2, 6:53 AM

	F14004205: D8533.id20242.diff
	Sat, Oct 26, 5:07 PM

	F13963750: D8533.diff
	Oct 15 2024, 5:40 PM

	Unknown Object (File)
	Oct 11 2024, 4:25 AM

	Unknown Object (File)
	Oct 6 2024, 6:57 AM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T4609: If you edit a comment to delete it, it displays wrong

Commits

Restricted Diffusion Commit
rP48910537b939: Fix rendering of comments deleted by editing

Summary

Fixes T4609. Steps are:

Make a comment.
Edit it.
Delete all the text.

We expect to see "This comment has been deleted." -- instead, things currently render goofy.

Root cause is that hasComment() means both "comment object exists" and "comment object is nonempty".

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20242.Mar 14 2014, 3:12 PM

epriestley retitled this revision from to Fix rendering of comments deleted by editing.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4609: If you edit a comment to delete it, it displays wrong.

Herald added subscribers: epriestley, aran.Mar 14 2014, 3:12 PM

btrahan accepted this revision.Mar 14 2014, 5:45 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2014, 5:45 PM

Closed by commit rP48910537b939 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

view/

PhabricatorApplicationTransactionView.php

8 lines

Diff 20256

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Fix rendering of comments deleted by editingClosedPublicActions