HomePhabricator

Fix an unusual nonterminating task graph node

Description

Fix an unusual nonterminating task graph node

Summary:
Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan:

  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12114

Differential Revision: https://secure.phabricator.com/D17211

Details

Provenance
epriestleyAuthored on Jan 17 2017, 3:32 PM
epriestleyPushed on Jan 17 2017, 5:18 PM
Reviewer
chad
Differential Revision
D17211: Fix an unusual nonterminating task graph node
Parents
rPa4a948561283: Hide dropdown menus when users click workflow items
Branches
Unknown
Tags
Unknown
Tasks
T12114: Upside-down segment in task graph
Build Status
Buildable 15287
Build 20115: Run Core Tests