Page MenuHomePhabricator

Fix an unusual nonterminating task graph node
ClosedPublic

Authored by epriestley on Jan 17 2017, 4:40 PM.
Tags
None
Referenced Files
F15453856: D17211.id41397.diff
Sat, Mar 29, 2:52 PM
F15453797: D17211.id41398.diff
Sat, Mar 29, 2:26 PM
F15450107: D17211.id.diff
Fri, Mar 28, 2:01 PM
F15447835: D17211.diff
Fri, Mar 28, 1:51 AM
F15445700: D17211.id.diff
Thu, Mar 27, 3:34 PM
F15445660: D17211.id41397.diff
Thu, Mar 27, 3:20 PM
F15442562: D17211.id41398.diff
Wed, Mar 26, 11:48 PM
F15442560: D17211.id41397.diff
Wed, Mar 26, 11:48 PM
Subscribers
None

Details

Summary

Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan
  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.