Page MenuHomePhabricator

Fix an unusual nonterminating task graph node
ClosedPublic

Authored by epriestley on Jan 17 2017, 4:40 PM.
Tags
None
Referenced Files
F18807659: D17211.id41397.diff
Sun, Oct 19, 2:47 AM
F18762609: D17211.diff
Oct 6 2025, 7:53 PM
F18625606: D17211.id41398.diff
Sep 15 2025, 11:08 PM
F18508420: D17211.id.diff
Sep 5 2025, 2:48 AM
F18500480: D17211.diff
Sep 4 2025, 9:06 PM
F18392445: D17211.id41398.diff
Aug 29 2025, 8:16 AM
F18392226: D17211.id41398.diff
Aug 29 2025, 8:07 AM
F18203428: D17211.id.diff
Aug 18 2025, 12:10 PM
Subscribers
None

Details

Summary

Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan
  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.