Page MenuHomePhabricator

Fix an unusual nonterminating task graph node
ClosedPublic

Authored by epriestley on Jan 17 2017, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 8:04 AM
Unknown Object (File)
Wed, Mar 20, 6:21 AM
Unknown Object (File)
Tue, Mar 19, 10:24 PM
Unknown Object (File)
Tue, Mar 19, 10:24 PM
Unknown Object (File)
Feb 6 2024, 2:53 AM
Unknown Object (File)
Feb 3 2024, 2:04 PM
Unknown Object (File)
Jan 23 2024, 3:30 AM
Unknown Object (File)
Jan 5 2024, 1:58 AM
Subscribers
None

Details

Summary

Fixes T12114. There were a couple of bugs here:

  • We could draw too many joining lines if a node had a parent with multiple descendants.
  • We could incorrectly ignore columns because of an unset().

I think this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues.

Test Plan
  • Unit tests.
  • My local repro is clean now:

Screen Shot 2017-01-17 at 8.36.55 AM.png (349×262 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.