Paths

Table of Contentst

Diffusion Phabricator 44f0664d2c6f

Add a "lock log" for debugging where locks are being held
44f0664d2c6f
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Add a "lock log" for debugging where locks are being held

Summary: Depends on D19173. Ref T13096. Adds an optional, disabled-by-default lock log to make it easier to figure out what is acquiring and holding locks.

Test Plan: Ran bin/lock log --enable, --disable, --name, etc. Saw sensible-looking output with log enabled and daemons restarted. Saw no additional output with log disabled and daemons restarted.

Maniphest Tasks: T13096

Differential Revision: https://secure.phabricator.com/D19174

Details

Provenance

epriestley	Authored on Mar 5 2018, 10:22 PM
epriestley	Pushed on Mar 6 2018, 1:55 AM

Differential Revision

D19174: Add a "lock log" for debugging where locks are being held

Parents

rPfd367adbaf85: Parameterize PhabricatorGlobalLock

Branches

Unknown

Tags

Unknown

Tasks

T13096: Implement a global lock log to make it easier to debug global locks

Build Status

Buildable 19741
Build 26738: Run Core Tests

Event Timeline

epriestley committed rP44f0664d2c6f: Add a "lock log" for debugging where locks are being held (authored by epriestley).Mar 6 2018, 1:55 AM

epriestley added a task: T13096: Implement a global lock log to make it easier to debug global locks.

Harbormaster completed building B19741: rP44f0664d2c6f: Add a "lock log" for debugging where locks are being held.Mar 6 2018, 1:56 AM

Changes (11)

Path

Size

bin/

resources/

sql/

autopatches/

20180305.lock.01.locklog.sql

scripts/

setup/

	manage_lock.php
	manage_webhook.php

src/

__phutil_library_map__.php

applications/

	daemon/	garbagecollector/
	people/	garbagecollector/

	PhabricatorDaemonLockLogGarbageCollector.php
	PeopleUserLogGarbageCollector.php

daemon/

management/

PhabricatorLockLogManagementWorkflow.php

storage/

PhabricatorDaemonLockLog.php

	daemon/	management/
	auth/	management/

	PhabricatorLockManagementWorkflow.php
	PhabricatorAuthManagementWorkflow.php

infrastructure/

daemon/

garbagecollector/

PhabricatorGarbageCollector.php

storage/

management/

workflow/

PhabricatorStorageManagementWorkflow.php

util/

PhabricatorGlobalLock.php

rP44f0664d2c6f

bin/lock

Loading...

resources/sql/autopatches/20180305.lock.01.locklog.sql

Loading...

scripts/setup/manage_lock.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/daemon/garbagecollector/PhabricatorDaemonLockLogGarbageCollector.php

Loading...

src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php

Loading...

src/applications/daemon/management/PhabricatorLockManagementWorkflow.php

Loading...

src/applications/daemon/storage/PhabricatorDaemonLockLog.php

Loading...

src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollector.php

Loading...

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...