HomePhabricator

Mark `renderActionDescription` as abstract

Description

Mark renderActionDescription as abstract

Summary:
I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896

Test Plan: N/A

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13779

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Aug 3 2015, 10:34 PM
Reviewer
Blessed Reviewers
Differential Revision
D13779: Mark `renderActionDescription` as abstract
Parents
rP5f76c71d781c: Share target filtering code in HeraldAction
Branches
Unknown
Tags
Unknown