Page MenuHomePhabricator

Mark `renderActionDescription` as abstract
ClosedPublic

Authored by joshuaspence on Aug 3 2015, 10:30 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4139305f73f0: Mark `renderActionDescription` as abstract
Summary

I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896
Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Mark `renderActionDescription` as abstract.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.Aug 3 2015, 10:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 10:32 PM
This revision was automatically updated to reflect the committed changes.