Differential D13779

Mark `renderActionDescription` as abstract
ClosedPublic
Actions

Authored by joshuaspence on Aug 3 2015, 10:30 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP4139305f73f0: Mark `renderActionDescription` as abstract

Summary

I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33282.Aug 3 2015, 10:30 PM

joshuaspence retitled this revision from to Mark `renderActionDescription` as abstract.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 3 2015, 10:30 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 3 2015, 10:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 3 2015, 10:32 PM

Closed by commit rP4139305f73f0: Mark `renderActionDescription` as abstract (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 3 2015, 10:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

action/

HeraldAction.php

2 lines

Diff 33283

View Options

src/applications/herald/action/HeraldAction.php

Mark `renderActionDescription` as abstractClosedPublicActions