Page MenuHomePhabricator
Differential D13779

Mark `renderActionDescription` as abstract
ClosedPublic
Actions

Authored by joshuaspence on Aug 3 2015, 10:30 PM.
Tags
None
Referenced Files
F15588189: D13779.id33283.diff
Fri, May 9, 5:18 AM
F15583835: D13779.id33282.diff
Thu, May 8, 12:06 AM
F15577622: D13779.diff
Tue, May 6, 3:04 PM
F15573163: D13779.diff
Mon, May 5, 7:46 PM
F15568234: D13779.id33282.diff
Fri, May 2, 11:12 PM
F15562881: D13779.id33283.diff
Wed, Apr 30, 4:49 AM
F15531595: D13779.id33282.diff
Wed, Apr 23, 12:09 PM
F15520532: D13779.id33282.diff
Sun, Apr 20, 7:06 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4139305f73f0: Mark `renderActionDescription` as abstract
Summary

I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896
Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33282.Aug 3 2015, 10:30 PM
joshuaspence retitled this revision from to Mark `renderActionDescription` as abstract.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 3 2015, 10:30 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 3 2015, 10:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 10:32 PM
Closed by commit rP4139305f73f0: Mark `renderActionDescription` as abstract (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 3 2015, 10:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
action/
2 lines

Diff 33283

View Options

src/applications/herald/action/HeraldAction.php

Loading...
Phabricator · Built by Phacility