HomePhabricator

Consider inline comments with draft checkmarks as "unsubmitted"

Description

Consider inline comments with draft checkmarks as "unsubmitted"

Summary:
Ref T12733. When a revision has unsubmitted checkmarks:

  • Color the banner yellow.
  • Show them in the "X unsubmitted" count.
  • Make the "X unsubmitted" button cycle between all drafts (written but unpublished comments) and "draft done" (checked but unsubmitted "Done" checkbox comments).

Test Plan:

  • Checked a "Done" box, saw "1 unsubmitted" and yellow banner.
  • Clicked "5 unsubmitted" repeatedly, saw it cycle through all unsubmitted comments and checkboxes.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision: https://secure.phabricator.com/D18127

Details