HomePhabricator

Recover more flexibly from an already-verified email

Description

Recover more flexibly from an already-verified email

Summary:
Ref T4140. We could hit a redirect loop for a user with a verified primary email address but no "is verified" flag on their account. This shouldn't be possible since the migration should have set the flag, but we can deal with it more gracefully when it does happen (maybe because users forgot to run storage/upgrade, or because of ghosts).

In the controller, check the same flag we check before forcing the user to the controller.

When verifying, allow the verification if either the email or user flag isn't set.

Test Plan: Hit /login/mustverify/; verified an address.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4140

Differential Revision: https://secure.phabricator.com/D7621

Details

Provenance
epriestleyAuthored on Nov 21 2013, 10:41 PM
Reviewer
btrahan
Differential Revision
D7621: Recover more flexibly from an already-verified email
Parents
rP13275860b18e: When stopping on redirect, show a full stack trace
Branches
Unknown
Tags
Unknown
Tasks
T4140: Cycle redirect when login new user

Event Timeline