Page MenuHomePhabricator

Recover more flexibly from an already-verified email
ClosedPublic

Authored by epriestley on Nov 21 2013, 10:08 PM.
Tags
None
Referenced Files
F19825047: D7621.diff
Mar 8 2026, 6:57 AM
F19749202: D7621.diff
Feb 15 2026, 8:02 PM
F19548794: D7621.id.diff
Jan 26 2026, 10:51 PM
F19526800: D7621.diff
Jan 18 2026, 8:13 PM
F18853055: D7621.diff
Oct 31 2025, 1:56 PM
F18820941: D7621.id.diff
Oct 22 2025, 6:05 PM
F18818396: D7621.diff
Oct 22 2025, 12:09 AM
F18580610: D7621.id17204.diff
Sep 11 2025, 4:03 AM
Subscribers

Details

Summary

Ref T4140. We could hit a redirect loop for a user with a verified primary email address but no "is verified" flag on their account. This shouldn't be possible since the migration should have set the flag, but we can deal with it more gracefully when it does happen (maybe because users forgot to run storage/upgrade, or because of ghosts).

In the controller, check the same flag we check before forcing the user to the controller.

When verifying, allow the verification if either the email or user flag isn't set.

Test Plan

Hit /login/mustverify/; verified an address.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped