Paths

Table of Contentst

Diffusion Phabricator 336ccfeea12e

Revert a fourth json_decode() which decodes possible scalars
Audited336ccfeea12e
Actions

Tags

None

Referenced Files

None

Subscribers

Description

Revert a fourth json_decode() which decodes possible scalars

See D12714, D12680.

Auditors: joshuaspence

Details

Auditors

Group Auditors

Provenance

epriestley	Authored on
epriestley	Pushed on May 5 2015, 8:13 PM

Parents

rP5f7ee505b6b7: Revert a third json_decode() which decodes possible scalars

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley committed rP336ccfeea12e: Revert a fourth json_decode() which decodes possible scalars (authored by epriestley).May 5 2015, 8:13 PM

epriestley added auditors: joshuaspence.

Herald added auditors: Fakhra.Aftab, Cowboy Commits. · View Herald TranscriptMay 5 2015, 8:13 PM

Oh my. I'm AFK at the moment, but I thought that phutil_json_decode could handle scalars? I'm guessing not.

joshuaspence mentioned this in D12725: Make phutil_json_decode more powerful.May 5 2015, 8:57 PM

chad accepted this commit.May 6 2015, 5:50 PM

Did you have any concerns with D12725? That should fix all of these I think.

joshuaspence accepted this commit.May 17 2015, 10:40 PM

Changes (1)

Path

Size

src/

applications/

differential/

conduit/

DifferentialSetDiffPropertyConduitAPIMethod.php

rP336ccfeea12e

src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php

Loading...