HomePhabricator

Use AphrontRequestStream to read request input

Description

Use AphrontRequestStream to read request input

Summary:
Ref T10604. This uses the new standalone stream reader introduced in D15483 to read request data, instead of putting the logic in PhabricatorStartup.

It also doesn't read request data until it specifically needs to. This supports, e.g., streaming Git LFS PUT requests, and streaming more types of requests in the future.

Test Plan: See D15483. Made various different types of requests and wasn't immediately able to break anything.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10604

Differential Revision: https://secure.phabricator.com/D15484

Details

Provenance
epriestleyAuthored on Mar 16 2016, 5:47 PM
epriestleyPushed on Mar 17 2016, 3:08 PM
Reviewer
chad
Differential Revision
D15484: Use AphrontRequestStream to read request input
Parents
rP51153a580cd6: Implement "git-lfs-authenticate" over SSH
Branches
Unknown
Tags
Unknown
Tasks
T10604: Allow application code to stream request data
Build Status
Buildable 11191
Build 13884: Run Core Tests