Differential D15484

Use AphrontRequestStream to read request input
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 6:06 PM.

Details

Reviewers

chad

Maniphest Tasks

T10604: Allow application code to stream request data

Commits

Restricted Diffusion Commit
rP2b02024e2329: Use AphrontRequestStream to read request input

Summary

Ref T10604. This uses the new standalone stream reader introduced in D15483 to read request data, instead of putting the logic in PhabricatorStartup.

It also doesn't read request data until it specifically needs to. This supports, e.g., streaming Git LFS PUT requests, and streaming more types of requests in the future.

Test Plan

See D15483. Made various different types of requests and wasn't immediately able to break anything.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37317.Mar 16 2016, 6:06 PM

epriestley retitled this revision from to Use AphrontRequestStream to read request input.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10604: Allow application code to stream request data.

Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 6:06 PM

chad accepted this revision.Mar 16 2016, 6:07 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 16 2016, 6:07 PM

Closed by commit rP2b02024e2329: Use AphrontRequestStream to read request input (authored by epriestley, committed by epriestley). · Explain WhyMar 17 2016, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

configuration/

AphrontDefaultApplicationConfiguration.php

17 lines

support/

PhabricatorStartup.php

61 lines

Diff 37331

View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php