Page MenuHomePhabricator

Added 'method' field to the HTTP request build step.
ClosedPublic

Authored by wotte on Mar 13 2014, 10:33 PM.

Details

Summary

This revision adds a 'method' field to the HTTP request harbormaster build step. This allows the user to specify GET, POST, DELETE, and PUT (limited by the underlying wrapper phabricator uses for HTTP requests). I'm not sure how much sense PUT makes, but oh well.

Existing plans shouldn't break, as if this field is an empty string, we default to POST, which is the old behavior.

Fixes T4604

Test Plan
  1. Verified that the empty string does, in fact, issue a POST request. Changed the method to be GET and observed that the problem described in T4604 is resolved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wotte retitled this revision from to Added 'method' field to the HTTP request build step..
wotte updated this object.
wotte edited the test plan for this revision. (Show Details)
wotte edited edge metadata.
epriestley added a reviewer: epriestley.

Works for me. Thanks!

This revision is now accepted and ready to land.Mar 13 2014, 10:49 PM
epriestley updated this revision to Diff 20217.
epriestley added a subscriber: wrotte.

Closed by commit rP29436dfe378c (authored by @wrotte, committed by @epriestley).