Page MenuHomePhabricator

Don't consider empty inlines when considering whether a revision has draft comments or not
ClosedPublic

Authored by epriestley on Mon, May 4, 5:29 PM.

Details

Summary

Ref T13513. When computing whether a revision has draft comments or not, ignore empty inlines.

Test Plan

Added empty inlines to a revision, no longer saw a yellow "draft" bubble in the list UI.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 5:29 PM
epriestley requested review of this revision.Mon, May 4, 5:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 8:17 PM
This revision was automatically updated to reflect the committed changes.