Page MenuHomePhabricator
Differential D21215

Don't consider empty inlines when considering whether a revision has draft comments or not
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 5:29 PM.
Tags
None
Referenced Files
F18772500: D21215.id50528.diff
Thu, Oct 9, 2:52 AM
F18710171: D21215.diff
Mon, Sep 29, 1:32 AM
F18673283: D21215.diff
Thu, Sep 25, 10:01 AM
F18592407: D21215.diff
Sep 12 2025, 12:11 PM
F18592344: D21215.diff
Sep 12 2025, 12:02 PM
F18592325: D21215.diff
Sep 12 2025, 11:58 AM
F18592272: D21215.diff
Sep 12 2025, 11:51 AM
F18592240: D21215.diff
Sep 12 2025, 11:44 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP27b7ba814a5a: Don't consider empty inlines when considering whether a revision has draft…
Summary

Ref T13513. When computing whether a revision has draft comments or not, ignore empty inlines.

Test Plan

Added empty inlines to a revision, no longer saw a yellow "draft" bubble in the list UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 4 2020, 5:29 PM
Harbormaster completed remote builds in B24335: Diff 50518.May 4 2020, 5:30 PM
epriestley requested review of this revision.May 4 2020, 5:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:17 PM
Closed by commit rP27b7ba814a5a: Don't consider empty inlines when considering whether a revision has draft… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP27b7ba814a5a: Don't consider empty inlines when considering whether a revision has draft….

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
11 lines

Diff 50528

View Options

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...
Phabricator · Built by Phacility