HomePhabricator

(stable) Stop doing an excessive amount of work in `diffusion.rawdiffquery`

Tags
None
Referenced Files
None
Subscribers
None
Tokens
"Baby Tequila" token, awarded by yelirekim.

Description

(stable) Stop doing an excessive amount of work in diffusion.rawdiffquery

Ref T11665.

Without -n 1, this logs the ENTIRE history of the repository. We
actually get the right result, but this is egregiously slow. Add -n 1
to return only one result.

It appears that I wrote this wrong way back in 2011, in D953. This
query is rarely used (until recently) which is likely why it has
escaped notice for so long.

Test Plan: Used Conduit console to execute diffusion.rawdiffquery.
Got the same results but spent 8ms instead of 200ms executing this
command, in a very small repository.

Details

Group Auditors
Cowboy Commits
Provenance
epriestleyAuthored on Sep 20 2016, 12:57 PM
epriestleyPushed on Sep 20 2016, 1:01 PM
Parents
rPa768a252af3b: (stable) Add a default value for messageCount so writes from old tiers survive…
Branches
Unknown
Tags
Unknown
Tasks
T11665: repo002.phacility.net is heavily loaded
Build Status
Buildable 13786
Build 17809: Run Core Tests