HomePhabricator

Refine error behavior of `bin/search index`

Description

Refine error behavior of bin/search index

Summary: Fixes T5991. If all requested documents failed to index, consider this a catastrophic failure and exit with an error code.

Test Plan:

  • Ran bin/search index --type TASK, observed successful exit despite a small number of un-indexable documents.
  • Ran bin/search index PHID-TASK-xxx for an invalid task, observed exception on exit after complete failure.
  • Ran normal indexing through daemons.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T5991

Differential Revision: https://secure.phabricator.com/D14174

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Sep 27 2015, 8:11 PM
Reviewer
chad
Differential Revision
D14174: Refine error behavior of `bin/search index`
Parents
rPc99508cfe26f: Explain upstream attitudes toward CLI exit codes
Branches
Unknown
Tags
Unknown
Tasks
T5991: `bin/search index` returns 0 on failure