Paths

Table of Contentst

Differential D14174

Refine error behavior of `bin/search index`
ClosedPublic
Actions

Authored by epriestley on Sep 27 2015, 5:50 PM.

Tags

None

Referenced Files

	F15283053: D14174.diff
	Tue, Mar 4, 4:56 AM

	Unknown Object (File)
	Sat, Feb 22, 12:23 AM

	Unknown Object (File)
	Wed, Feb 12, 12:01 AM

	Unknown Object (File)
	Wed, Feb 12, 12:01 AM

	Unknown Object (File)
	Wed, Feb 12, 12:01 AM

	Unknown Object (File)
	Wed, Feb 12, 12:01 AM

	Unknown Object (File)
	Sat, Feb 8, 11:23 PM

	Unknown Object (File)
	Sat, Feb 8, 11:23 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T5991: `bin/search index` returns 0 on failure

Commits

Restricted Diffusion Commit
rP24845c70b918: Refine error behavior of `bin/search index`

Summary

Fixes T5991. If all requested documents failed to index, consider this a catastrophic failure and exit with an error code.

Test Plan

Ran bin/search index --type TASK, observed successful exit despite a small number of un-indexable documents.
Ran bin/search index PHID-TASK-xxx for an invalid task, observed exception on exit after complete failure.
Ran normal indexing through daemons.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34244.Sep 27 2015, 5:50 PM

epriestley retitled this revision from to Refine error behavior of `bin/search index`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5991: `bin/search index` returns 0 on failure.

epriestley mentioned this in T5991: `bin/search index` returns 0 on failure.Sep 27 2015, 5:54 PM

chad accepted this revision.Sep 27 2015, 6:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 27 2015, 6:52 PM

Closed by commit rP24845c70b918: Refine error behavior of `bin/search index` (authored by epriestley, committed by epriestley). · Explain WhySep 27 2015, 8:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

index/

PhabricatorSearchDocumentIndexer.php

64 lines

management/

PhabricatorSearchManagementIndexWorkflow.php

15 lines

worker/

PhabricatorSearchWorker.php

12 lines

Diff 34246

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php

Loading...

src/applications/search/worker/PhabricatorSearchWorker.php

Loading...