HomePhabricator

Reduce the amount of boilerplate that implementing FerretInterface requires

Description

Reduce the amount of boilerplate that implementing FerretInterface requires

Summary:
See brief discussion in D18554. All the index tables are the same for every application (and, at this point, seem unlikely to change) and we never actually pass these objects around (they're only used internally).

In some other cases (like Transactions) not every application has the same tables (for example, Differential has extra field for inline comments), and/or we pass the objects around (lots of stuff uses $xactions directly).

However, in this case, and in Edges, we don't interact with any representation of the database state directly in much of the code, and it doesn't change from application to application.

Just automatically define document, field, and ngram tables for anything which implements FerretInterface. This makes the query and index logic a tiny bit messier but lets us delete a ton of boilerplate classes.

Test Plan: Indexed objects, searched for objects. Same results as before with much less code. Ran bin/storage upgrade, got a clean bill of health.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12819

Differential Revision: https://secure.phabricator.com/D18559

Details

Provenance
epriestleyAuthored on Sep 7 2017, 6:03 PM
epriestleyPushed on Sep 7 2017, 8:23 PM
Reviewer
chad
Differential Revision
D18559: Reduce the amount of boilerplate that implementing FerretInterface requires
Parents
rP2020c1e7bd22: Support Ferret engine for Passphrase credentials
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18376
Build 24744: Run Core Tests