Paths

Table of Contentst

Diffusion Phabricator 18a06b78acf5

(stable) Add a missing "null" check when rebuilding old/new diff content
18a06b78acf5
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

(stable) Add a missing "null" check when rebuilding old/new diff content

Summary:
See https://discourse.phabricator-community.org/t/exceptions-when-viewing-diffs/3787. This list may include null values.

Until PHP 7.4, $x = null; echo $x['y']; does not emit a warning. Sneaky!

Test Plan:

Traced null values from reparseHunksForSpecialAttributes(), saw them no longer incorporated into corpus bodies.
This has some amount of test coverage.

Differential Revision: https://secure.phabricator.com/D21169

Details

Provenance

epriestley	Authored on Apr 25 2020, 4:16 PM
epriestley	Pushed on Apr 25 2020, 4:23 PM

Differential Revision

D21169: Add a missing "null" check when rebuilding old/new diff content

Parents

rP2af8133e88b5: (stable) When proxying HTTP repository responses from repository nodes, discard…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 24225
Build 33365: Run Core Tests

Event Timeline

epriestley committed rP18a06b78acf5: (stable) Add a missing "null" check when rebuilding old/new diff content (authored by epriestley).Apr 25 2020, 4:23 PM

epriestley added an edge: D21169: Add a missing "null" check when rebuilding old/new diff content.

Harbormaster completed building B24225: rP18a06b78acf5: (stable) Add a missing "null" check when rebuilding old/new diff content.Apr 25 2020, 4:24 PM

Changes (1)

Path

Size

src/

applications/

differential/

parser/

DifferentialHunkParser.php

rP18a06b78acf5

src/applications/differential/parser/DifferentialHunkParser.php

Loading...