HomePhabricator

Skip anon functions in symbol generation script

Description

Skip anon functions in symbol generation script

Summary:
Filters closures out of symbol generator script, per @epriestley's
comment in T4334

Test Plan:
Before:

eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php
  function php  /closure.php
 d function php 10 /closure.php
  function php  /closure.php
 a class php 3 /closure.php
a b method php 4 /closure.php

After:

eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php
 d function php 10 /closure.php
 a class php 3 /closure.php
a b method php 4 /closure.php

eric@eric-dev ~/phabricator/scripts/symbols: cat closure.php

<?php

class a {
  function b() {
    $c = function() { return 1; };
    $c();
  }
}

function d() {
  return 2;
}
$e = function() {
  return 3;
};

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley

CC: epriestley, Korvin, aran

Differential Revision: https://secure.phabricator.com/D8054

Details

Provenance
FirehedAuthored on
epriestleyCommitted on Jan 24 2014, 1:01 AM
epriestleyPushed on Jan 24 2014, 1:01 AM
Reviewer
epriestley
Differential Revision
D8054: Skip anon functions in symbol generation script
Parents
rPfebc494737be: Actually check CSRF on Password and LDAP forms
Branches
Unknown
Tags
Unknown

Event Timeline