Filters closures out of symbol generator script, per @epriestley's
comment in T4334
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP14f070a0af79: Skip anon functions in symbol generation script
Before:
eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php function php /closure.php d function php 10 /closure.php function php /closure.php a class php 3 /closure.php a b method php 4 /closure.php
After:
eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php d function php 10 /closure.php a class php 3 /closure.php a b method php 4 /closure.php
eric@eric-dev ~/phabricator/scripts/symbols: cat closure.php
<?php class a { function b() { $c = function() { return 1; }; $c(); } } function d() { return 2; } $e = function() { return 3; };
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Thanks!
StdClass
I think if this is spelled stdClass we recognize it (maybe).
scripts/symbols/generate_php_symbols.php | ||
---|---|---|
38 | For completeness this could have a strlen() check, but you can't name a function "0" anyway I suppose. |