Page MenuHomePhabricator

Skip anon functions in symbol generation script
ClosedPublic

Authored by Firehed on Jan 24 2014, 12:58 AM.
Tags
None
Referenced Files
F15477626: D8054.id18222.diff
Mon, Apr 7, 4:46 PM
F15476658: D8054.id18222.diff
Mon, Apr 7, 8:20 AM
F15466432: D8054.id.diff
Thu, Apr 3, 5:28 AM
F15465500: D8054.diff
Wed, Apr 2, 7:36 PM
F15462381: D8054.diff
Tue, Apr 1, 2:44 PM
F15457447: D8054.diff
Sun, Mar 30, 4:49 PM
F15424024: D8054.id18221.diff
Sat, Mar 22, 7:55 PM
F15396633: D8054.id18221.diff
Sun, Mar 16, 3:30 PM
Tokens
"Mountain of Wealth" token, awarded by raguiar.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP14f070a0af79: Skip anon functions in symbol generation script
Summary

Filters closures out of symbol generator script, per @epriestley's
comment in T4334

Test Plan

Before:

eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php 
  function php  /closure.php
 d function php 10 /closure.php
  function php  /closure.php
 a class php 3 /closure.php
a b method php 4 /closure.php

After:

eric@eric-dev ~/phabricator/scripts/symbols: echo 'closure.php' | ./generate_php_symbols.php 
 d function php 10 /closure.php
 a class php 3 /closure.php
a b method php 4 /closure.php

eric@eric-dev ~/phabricator/scripts/symbols: cat closure.php

<?php

class a {
  function b() {
    $c = function() { return 1; };
    $c();
  }
}

function d() {
  return 2;
}
$e = function() {
  return 3;
};

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Thanks!

StdClass

I think if this is spelled stdClass we recognize it (maybe).

scripts/symbols/generate_php_symbols.php
38

For completeness this could have a strlen() check, but you can't name a function "0" anyway I suppose.

Closed by commit rP14f070a0af79 (authored by @Firehed, committed by @epriestley).