Tighten query compiler rules around spaces inside and after operators
143f86d60b5a
Actions

Description

Tighten query compiler rules around spaces inside and after operators

Summary:
Ref T13509. Since title:- cat is now ambiguous, forbid spaces after operators.

Also, forbid spaces inside operators, although this has no effect today.

Test Plan: Added unit tests, ran unit tests.

Maniphest Tasks: T13509

Differential Revision: https://secure.phabricator.com/D21109

Details

Provenance

epriestley	Authored on Apr 14 2020, 4:28 PM
epriestley	Pushed on Apr 14 2020, 5:51 PM

Differential Revision

D21109: Tighten query compiler rules around spaces inside and after operators

Parents

rP8fa8d0e6483c: Make Ferret query functions sticky only if their values are not quoted

Branches

Unknown

Tags

Unknown

Tasks

T13509: Support "field present" and "field absent" operators in Ferret

Build Status

Buildable 24098
Build 33179: Run Core Tests

Event Timeline

epriestley committed rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators (authored by epriestley).Apr 14 2020, 5:51 PM

epriestley added a task: T13509: Support "field present" and "field absent" operators in Ferret.

epriestley added an edge: D21109: Tighten query compiler rules around spaces inside and after operators.

Harbormaster completed building B24098: rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators.Apr 14 2020, 5:53 PM

Changes (2)

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

__tests__/

PhutilSearchQueryCompilerTestCase.php

rP143f86d60b5a

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php