Page MenuHomePhabricator
Differential D21109

Tighten query compiler rules around spaces inside and after operators
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 5:18 PM.
Tags
None
Referenced Files
F15480201: D21109.id50273.diff
Tue, Apr 8, 12:40 PM
F15471617: D21109.id.diff
Sat, Apr 5, 6:23 AM
F15469391: D21109.diff
Fri, Apr 4, 12:40 PM
F15434499: D21109.id.diff
Tue, Mar 25, 4:08 AM
F15424771: D21109.id50273.diff
Sun, Mar 23, 12:16 AM
F15407161: D21109.id50280.diff
Tue, Mar 18, 4:10 PM
F15405353: D21109.id.diff
Tue, Mar 18, 11:13 AM
F15373321: D21109.id50280.diff
Mar 12 2025, 3:30 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13509: Support "field present" and "field absent" operators in Ferret
Commits
rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators
Summary

Ref T13509. Since title:- cat is now ambiguous, forbid spaces after operators.

Also, forbid spaces inside operators, although this has no effect today.

Test Plan

Added unit tests, ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2020, 5:18 PM
Harbormaster completed remote builds in B24091: Diff 50273.Apr 14 2020, 5:19 PM
epriestley requested review of this revision.Apr 14 2020, 5:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:52 PM
Closed by commit rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
compiler/
55 lines
__tests__/
28 lines

Diff 50280

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

Loading...
View Options

src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php

Loading...
Phabricator · Built by Phacility