Page MenuHomePhabricator

Make profile menu `/edit/` requests explicitly 404
ClosedPublic

Authored by epriestley on Jan 9 2017, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 23, 12:14 PM
Unknown Object (File)
Feb 13 2025, 2:15 AM
Unknown Object (File)
Feb 9 2025, 3:06 AM
Unknown Object (File)
Feb 9 2025, 3:06 AM
Unknown Object (File)
Feb 9 2025, 3:06 AM
Unknown Object (File)
Feb 2 2025, 7:26 AM
Unknown Object (File)
Jan 26 2025, 10:17 PM
Unknown Object (File)
Jan 25 2025, 5:54 PM
Subscribers
None

Details

Summary

See D17160. Previously, the /edit/ route was never linked, but fataled when accessed. Make it 404 instead.

Also, fix an issue where editing "Application" menu items would fail because they didn't have a viewer.

Test Plan
  • Hit /edit/, got a 404.
  • Edited an "Application" item.
  • Moved, added, deleted, and edited other items.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 9 2017, 8:12 PM
This revision was automatically updated to reflect the committed changes.