Paths

Table of Contentst

` requests explicitly 404
ClosedPublic
Actions

Authored by epriestley on Jan 9 2017, 8:09 PM.

Tags

None

Referenced Files

	F19063183: D17165.id.diff
	Nov 29 2025, 6:05 PM

	F19052996: D17165.diff
	Nov 28 2025, 6:46 AM

	F18967518: D17165.diff
	Nov 14 2025, 9:22 PM

	F18920542: D17165.diff
	Nov 9 2025, 1:04 PM

	F18839651: D17165.id.diff
	Oct 27 2025, 6:01 PM

	F18834158: D17165.diff
	Oct 26 2025, 6:59 AM

	F18833860: D17165.diff
	Oct 26 2025, 6:19 AM

	F18739528: D17165.diff
	Oct 1 2025, 9:49 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP0e1388340c5a: Make profile menu `/edit/` requests explicitly 404

Summary

See D17160. Previously, the /edit/ route was never linked, but fataled when accessed. Make it 404 instead.

Also, fix an issue where editing "Application" menu items would fail because they didn't have a viewer.

Test Plan

Hit /edit/, got a 404.
Edited an "Application" item.
Moved, added, deleted, and edited other items.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 9 2017, 8:09 PM

Harbormaster completed remote builds in B15164: Diff 41277.Jan 9 2017, 8:10 PM

chad accepted this revision.Jan 9 2017, 8:12 PM

This revision is now accepted and ready to land.Jan 9 2017, 8:12 PM

Closed by commit rP0e1388340c5a: Make profile menu `/edit/` requests explicitly 404 (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2017, 8:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

10 lines

query/

PhabricatorProfileMenuItemConfigurationQuery.php

1 line

Diff 41279

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php