HomePhabricator

Make Cmd+Enter work to submit a form

Description

Make Cmd+Enter work to submit a form

Summary:
Fixes T3010.

keydown is what you're supposed to use for special keys like Enter; keypress didn't work for me for Cmd+Enter on Chrome.

Test Plan: Submitted a Differential field with Cmd+Enter on Chrome Mac. Also made sure Ctrl+Enter still works and Opt+Enter does not.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T3010

Differential Revision: https://secure.phabricator.com/D8699

Details

Provenance
sophiebitsAuthored on
epriestleyCommitted on Apr 4 2014, 2:00 AM
epriestleyPushed on Apr 4 2014, 2:00 AM
Reviewer
Blessed Reviewers
Differential Revision
D8699: Make Cmd+Enter work to submit a form
Parents
rPe3b5737d02fb: Support CustomField in Herald, mostly
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline