Paths

Table of Contentst

Diffusion Phabricator 07767fda00ab

Use direct inclusion, not submodules, to bring Javelin into Phabricator
Audited07767fda00ab
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Use direct inclusion, not submodules, to bring Javelin into Phabricator

Summary:
Submoduling is slightly convenient for developers but hellishly difficult for many users. Since we make about a dozen updates to Javelin per year, just include the source directly.

Even if we run git submodule status more often, this creates additional problems for users with PATH misconfigured.

Fixes T2062 by nuking it from orbit.

Test Plan: Loaded site, browsed around. Grepped for references to submodules.

Reviewers: btrahan, vrana

CC: aran

Maniphest Tasks: T2062

Differential Revision: https://secure.phabricator.com/D4581

Details

Auditors

Provenance

Authored on

Differential Revision

D4581: Use direct inclusion, not submodules, to bring Javelin into Phabricator

Parents

rP22c64c67ffca: Fix performance problem for large task queues

Branches

Unknown

Tags

Unknown

Tasks

Restricted Maniphest Task

Event Timeline

It seems that this has broken JS minification. We can solve it by copying jsxmin to /externals/ or we can start depending on Javelin the same way as we depend on libphutil.

My plan is to bring javelinsymbols and jsxmin into the project optionally by having users build and symlink them into support/bin/ (see T2378).

Possibly we should have a fallback minifier too, which just strips comments and whitespace with dumb regexps. This is probably 90% of the benefit for 2-3 lines of code.

(I don't want to add a javelin/ dependency or require users build any binaries to run Phabricator.)

D5670

I really wouldn't try to minify JS with a dumb regexp. But maybe we can use my JS minifier implemented in PHP JsShrink?

Changes (90)

Path

Size

externals/

event-stop-and-kill.js

behaviors.diviner

event_delegation.diviner

sigils_metadata.diviner

facebook.diviner

ReactorNodeCalmer.js

ViewInterpreter.js

ViewPlaceholder.js

ViewRenderer.js

ViewInterpreter.js

ViewRenderer.js

TypeaheadNormalizer.js

TypeaheadCompositeSource.js

TypeaheadOnDemandSource.js

TypeaheadPreloadedSource.js

TypeaheadSource.js

TypeaheadStaticSource.js

scripts/

install/

install_rhel-derivs.sh

install_ubuntu.sh

update_phabricator.sh

src/

__celerity_resource_map__.php

applications/

cache/

PhabricatorCaches.php

docs/

installation_guide.diviner

infrastructure/

PhabricatorSetup.php

lint/

linter/

PhabricatorJavelinLinter.php

webroot/

rsrc/

js/

rP07767fda00ab

.gitmodules

Loading...

externals/javelin

Loading...

externals/javelinjs/.gitignore

Loading...

externals/javelinjs/LICENSE

Loading...

externals/javelinjs/README

Loading...

externals/javelinjs/src/core/Event.js

Loading...

externals/javelinjs/src/core/Stratcom.js

Loading...

externals/javelinjs/src/core/tests/event-stop-and-kill.js

Loading...

externals/javelinjs/src/core/tests/install.js

Loading...

externals/javelinjs/src/core/tests/stratcom.js

Loading...

externals/javelinjs/src/core/tests/util.js

Loading...

externals/javelinjs/src/core/init.js

Loading...

externals/javelinjs/src/core/install.js

Loading...

externals/javelinjs/src/core/util.js

Loading...

externals/javelinjs/src/docs/Base.js

Loading...

externals/javelinjs/src/docs/concepts/behaviors.diviner

Loading...

externals/javelinjs/src/docs/concepts/event_delegation.diviner

Loading...

externals/javelinjs/src/docs/concepts/sigils_metadata.diviner

Loading...

externals/javelinjs/src/docs/facebook.diviner

Loading...

externals/javelinjs/src/docs/onload.js

Loading...

externals/javelinjs/src/ext/fx/Color.js

Loading...

externals/javelinjs/src/ext/fx/FX.js

Loading...

externals/javelinjs/src/ext/reactor/core/DynVal.js

Loading...

externals/javelinjs/src/ext/reactor/core/Reactor.js

Loading...

externals/javelinjs/src/ext/reactor/core/ReactorNode.js

Loading...

externals/javelinjs/src/ext/reactor/core/ReactorNodeCalmer.js

Loading...

externals/javelinjs/src/ext/reactor/dom/RDOM.js

Loading...

externals/javelinjs/src/ext/view/HTMLView.js

Loading...

externals/javelinjs/src/ext/view/View.js

Loading...

externals/javelinjs/src/ext/view/ViewInterpreter.js

Loading...

externals/javelinjs/src/ext/view/ViewPlaceholder.js

Loading...

externals/javelinjs/src/ext/view/ViewRenderer.js

Loading...

externals/javelinjs/src/ext/view/ViewVisitor.js

Loading...

externals/javelinjs/src/ext/view/tests/HTMLView.js

Loading...

externals/javelinjs/src/ext/view/tests/View.js

Loading...

externals/javelinjs/src/ext/view/tests/ViewInterpreter.js

Loading...

externals/javelinjs/src/ext/view/tests/ViewRenderer.js

Loading...

externals/javelinjs/src/lib/Cookie.js

Loading...

externals/javelinjs/src/lib/DOM.js

Loading...

externals/javelinjs/src/lib/History.js

Loading...

externals/javelinjs/src/lib/JSON.js

Loading...

externals/javelinjs/src/lib/Mask.js

Loading...

externals/javelinjs/src/lib/Request.js

Loading...

externals/javelinjs/src/lib/Resource.js

Loading...

externals/javelinjs/src/lib/URI.js

Loading...

externals/javelinjs/src/lib/Vector.js

Loading...

externals/javelinjs/src/lib/Workflow.js

Loading...

externals/javelinjs/src/lib/tests/Cookie.js

Loading...

externals/javelinjs/src/lib/tests/DOM.js

Loading...

externals/javelinjs/src/lib/tests/JSON.js

Loading...

externals/javelinjs/src/lib/tests/URI.js

Loading...

externals/javelinjs/src/lib/tests/behavior.js

Loading...

externals/javelinjs/src/lib/behavior.js

Loading...

externals/javelinjs/src/lib/control/tokenizer/Tokenizer.js

Loading...

externals/javelinjs/src/lib/control/typeahead/Typeahead.js

Loading...

externals/javelinjs/src/lib/control/typeahead/normalizer/TypeaheadNormalizer.js

Loading...

externals/javelinjs/src/lib/control/typeahead/source/TypeaheadCompositeSource.js

Loading...

externals/javelinjs/src/lib/control/typeahead/source/TypeaheadOnDemandSource.js

Loading...

externals/javelinjs/src/lib/control/typeahead/source/TypeaheadPreloadedSource.js

Loading...

externals/javelinjs/src/lib/control/typeahead/source/TypeaheadSource.js

Loading...

externals/javelinjs/src/lib/control/typeahead/source/TypeaheadStaticSource.js

Loading...

scripts/install/install_rhel-derivs.sh

Loading...

scripts/install/install_ubuntu.sh

Loading...

scripts/install/update_phabricator.sh

Loading...

src/__celerity_resource_map__.php

Loading...

src/applications/cache/PhabricatorCaches.php

Loading...

src/docs/installation_guide.diviner

Loading...

src/infrastructure/PhabricatorSetup.php

Loading...

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

Loading...

webroot/rsrc/js/javelin

Loading...