HomePhabricator

Explicitly add rel="noreferrer" to all external links

Description

Explicitly add rel="noreferrer" to all external links

Summary: See D19117. Instead of automatically figuring this out inside phutil_tag(), explicitly add rel="noreferrer" at the application level to all external links.

Test Plan:

  • Grepped for _blank, isValidRemoteURIForLink, checked all callsites for user-controlled data.
  • Created a link menu item, verified noreferrer in markup.
  • Created a link custom field, verified no referrer in markup.
  • Verified noreferrer for {nav href=...}.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D19118

Details

Provenance
epriestleyAuthored on Feb 18 2018, 1:37 AM
epriestleyPushed on Feb 18 2018, 1:46 AM
Differential Revision
D19118: Explicitly add rel="noreferrer" to all external links
Parents
rPeb3fd2b7f513: Fix an issue with marking aborted buildables failed when more than one build is…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19620
Build 26560: Run Core Tests