Page MenuHomePhabricator

Remove autodetection for whether links need "noreferrer"
ClosedPublic

Authored by epriestley on Feb 18 2018, 1:09 AM.
Tags
None
Referenced Files
F15466167: D19117.id45811.diff
Thu, Apr 3, 2:23 AM
F15457414: D19117.id.diff
Sun, Mar 30, 4:15 PM
F15423630: D19117.id45809.diff
Sat, Mar 22, 4:21 PM
F15391112: D19117.id45811.diff
Sat, Mar 15, 8:16 AM
F15338474: D19117.id45809.diff
Sun, Mar 9, 11:00 AM
F15338473: D19117.id.diff
Sun, Mar 9, 11:00 AM
F15336946: D19117.diff
Sun, Mar 9, 3:36 AM
Unknown Object (File)
Jan 24 2025, 2:37 AM
Subscribers
None

Details

Summary

Via HackerOne. See https://hackerone.com/reports/317243.

We're still detecting these wrong because browsers treat <a href=" /<newline><tab>\evil.com">click here</a> as a valid protocol-relative link to evil.com.

Just give up and add "noreferrer" at the application level at all callsites, like we do with target="_blank" already.

Test Plan

Added failing tests; ran unit tests. See also next change.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable