HomePhabricator

Remove hard-coding of diff line height

Tags
None
Referenced Files
F1310447: Screen Shot 2016-05-12 at 4.58.50 PM.png
May 16 2016, 5:21 PM
F1310446: Screen Shot 2016-05-12 at 4.58.00 PM.png
May 16 2016, 5:21 PM
F1310445: Screen Shot 2016-05-12 at 4.48.24 PM.png
May 16 2016, 5:21 PM
Subscribers
None

Description

Remove hard-coding of diff line height

Summary: Fixes T10959. This is the smallest/simplest fix that I could come up with, and I wasn't able to break it. Basically, I removed "line-height" and then adjusted other rules until the defaults looked reasonable again.

Test Plan:
Here's 24px / 48px impact or something like it:

Screen Shot 2016-05-12 at 4.48.24 PM.png (193×910 px, 40 KB)

Screen Shot 2016-05-12 at 4.58.00 PM.png (485×1 px, 91 KB)

Here's normal stuff working properly without weird artifacts on the highlighting:

Screen Shot 2016-05-12 at 4.58.50 PM.png (381×1 px, 69 KB)

Also tested Firefox and Chrome and got similar results.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: wxm20073527, Korvin

Maniphest Tasks: T10959

Differential Revision: https://secure.phabricator.com/D15905

Details