HomePhabricator

Whitelist allowed editor protocols

Description

Whitelist allowed editor protocols

Summary:
This is the other half of D8548. Specifically, the attack here was to set your own editor link to javascript\n:... and then you could XSS yourself. This isn't a hugely damaging attack, but we can be more certain by adding a whitelist here.

We already whitelist linkable protocols in remarkup (uri.allowed-protocols) in general.

Test Plan:
Tried to set and use valid/invalid editor URIs.

Screen_Shot_2014-03-17_at_11.45.33_AM.png (996×1 px, 115 KB)

Screen_Shot_2014-03-17_at_11.45.29_AM.png (996×1 px, 205 KB)

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8551

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 17 2014, 8:00 PM
Reviewer
btrahan
Differential Revision
D8551: Whitelist allowed editor protocols
Parents
rPced70f6b3278: Make install documentation more clear about Windows support
Branches
Unknown
Tags
Unknown

Event Timeline