Paths

Table of Contentst

Filter "javascript:" URIs more aggressively
ClosedPublic
Actions

Authored by epriestley on Mar 16 2014, 2:25 PM.

Tags

None

Referenced Files

	F18027906: D8548.id20283.diff
	Sat, Aug 2, 10:41 PM

	F17957536: D8548.diff
	Fri, Aug 1, 6:22 AM

	F17953150: D8548.id20282.diff
	Fri, Aug 1, 2:48 AM

	F17953029: D8548.id20283.diff
	Fri, Aug 1, 2:42 AM

	F17951546: D8548.id20293.diff
	Fri, Aug 1, 1:27 AM

	F17949576: D8548.id20281.diff
	Thu, Jul 31, 11:41 PM

	F17941454: D8548.diff
	Thu, Jul 31, 5:29 AM

	F17665672: D8548.id20282.diff
	Sat, Jul 12, 8:22 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

rPHU9678247c9f4c: Filter "javascript:" URIs more aggressively

Summary

Some browsers interpret javascript\n: as a Javascript URI. Be significantly more aggressive in normalizing URIs when looking for javascript: hrefs.

Test Plan

Added and executed unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20281.Mar 16 2014, 2:25 PM

epriestley retitled this revision from to Filter "javascript:" URIs more aggressively.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley.Mar 16 2014, 2:25 PM

Add a test case for not normalizing capital letters away.

Add a test case for another true negative.

btrahan accepted this revision.Mar 17 2014, 6:12 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 17 2014, 6:12 PM

Closed by commit rPHU9678247c9f4c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

__tests__/

PhutilMarkupTestCase.php

33 lines

render.php

33 lines

Diff 20293

View Options

src/markup/tests/PhutilMarkupTestCase.php

View Options

Filter "javascript:" URIs more aggressivelyClosedPublicActions