Paths

Table of Contentst

Filter "javascript:" URIs more aggressively
ClosedPublic
Actions

Authored by epriestley on Mar 16 2014, 2:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 11:32 PM

	Unknown Object (File)
	Tue, Dec 17, 1:45 PM

	Unknown Object (File)
	Wed, Dec 11, 6:54 PM

	Unknown Object (File)
	Mon, Dec 9, 3:25 PM

	Unknown Object (File)
	Sun, Dec 8, 2:58 AM

	Unknown Object (File)
	Thu, Dec 5, 12:00 PM

	Unknown Object (File)
	Nov 27 2024, 5:49 AM

	Unknown Object (File)
	Nov 22 2024, 11:33 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

rPHU9678247c9f4c: Filter "javascript:" URIs more aggressively

Summary

Some browsers interpret javascript\n: as a Javascript URI. Be significantly more aggressive in normalizing URIs when looking for javascript: hrefs.

Test Plan

Added and executed unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20281.Mar 16 2014, 2:25 PM

epriestley retitled this revision from to Filter "javascript:" URIs more aggressively.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley.Mar 16 2014, 2:25 PM

Add a test case for not normalizing capital letters away.

Add a test case for another true negative.

btrahan accepted this revision.Mar 17 2014, 6:12 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 17 2014, 6:12 PM

Closed by commit rPHU9678247c9f4c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

__tests__/

PhutilMarkupTestCase.php

33 lines

render.php

33 lines

Diff 20293

View Options

src/markup/tests/PhutilMarkupTestCase.php

View Options

Filter "javascript:" URIs more aggressivelyClosedPublicActions