Page MenuHomePhabricator

Filter "javascript:" URIs more aggressively
ClosedPublic

Authored by epriestley on Mar 16 2014, 2:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 9 2025, 2:04 AM
Unknown Object (File)
Jun 5 2025, 12:26 PM
Unknown Object (File)
May 20 2025, 2:25 PM
Unknown Object (File)
May 6 2025, 1:00 PM
Unknown Object (File)
Apr 26 2025, 9:22 AM
Unknown Object (File)
Apr 22 2025, 10:47 PM
Unknown Object (File)
Apr 22 2025, 8:31 PM
Unknown Object (File)
Apr 22 2025, 7:15 PM
Subscribers

Details

Summary

Some browsers interpret javascript\n: as a Javascript URI. Be significantly more aggressive in normalizing URIs when looking for javascript: hrefs.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Filter "javascript:" URIs more aggressively.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Add a test case for not normalizing capital letters away.
  • Add a test case for another true negative.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2014, 6:12 PM
epriestley updated this revision to Diff 20293.

Closed by commit rPHU9678247c9f4c (authored by @epriestley).