Paths

Table of Contentst

Filter "javascript:" URIs more aggressively
ClosedPublic
Actions

Authored by epriestley on Mar 16 2014, 2:25 PM.

Tags

None

Referenced Files

	F15529828: D8548.id20281.diff
	Tue, Apr 22, 10:47 PM

	F15529528: D8548.id20283.diff
	Tue, Apr 22, 8:31 PM

	F15529381: D8548.id.diff
	Tue, Apr 22, 7:15 PM

	F15527495: D8548.id20282.diff
	Tue, Apr 22, 4:05 AM

	F15524037: D8548.diff
	Mon, Apr 21, 5:34 AM

	F15515701: D8548.id20283.diff
	Fri, Apr 18, 12:51 PM

	F15491813: D8548.diff
	Sat, Apr 12, 7:49 AM

	F15490794: D8548.id20282.diff
	Fri, Apr 11, 8:37 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

rPHU9678247c9f4c: Filter "javascript:" URIs more aggressively

Summary

Some browsers interpret javascript\n: as a Javascript URI. Be significantly more aggressive in normalizing URIs when looking for javascript: hrefs.

Test Plan

Added and executed unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20281.Mar 16 2014, 2:25 PM

epriestley retitled this revision from to Filter "javascript:" URIs more aggressively.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley.Mar 16 2014, 2:25 PM

Add a test case for not normalizing capital letters away.

Add a test case for another true negative.

btrahan accepted this revision.Mar 17 2014, 6:12 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 17 2014, 6:12 PM

Closed by commit rPHU9678247c9f4c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

__tests__/

PhutilMarkupTestCase.php

33 lines

render.php

33 lines

Diff 20293

View Options

src/markup/tests/PhutilMarkupTestCase.php

View Options

Filter "javascript:" URIs more aggressivelyClosedPublicActions