Diffusion Phabricator 037c749ef332

Fix missing setQuoteRef() on Commit detail pages in Diffusion
037c749ef332
Actions

Description

Fix missing setQuoteRef() on Commit detail pages in Diffusion

Summary: Fixes T12253.

Test Plan:

Before change: used "Quote Comment", saw "In null, alice wrote:" in quoted text.
After change: used "Quote Comment", saw proper reference to the commit/page. Clicked reference, was sent to the comment properly.

Screen Shot 2017-02-13 at 7.39.49 AM.png (523×715 px, 59 KB)

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T12253

Differential Revision: https://secure.phabricator.com/D17343

Details

Provenance

epriestley	Authored on Feb 13 2017, 3:39 PM
epriestley	Pushed on Feb 13 2017, 3:44 PM

Reviewer

avivey

Differential Revision

D17343: Fix missing setQuoteRef() on Commit detail pages in Diffusion

Parents

rP554c4f10c5df: Remove Copy Dashboard

Branches

Unknown

Tags

Unknown

Tasks

T12253: null in remarkup rather than comment reference when quoting a comment in audit

Build Status

Buildable 15609
Build 20598: Run Core Tests

Event Timeline

epriestley committed rP037c749ef332: Fix missing setQuoteRef() on Commit detail pages in Diffusion (authored by epriestley).Feb 13 2017, 3:44 PM

epriestley added a task: T12253: null in remarkup rather than comment reference when quoting a comment in audit.

Harbormaster completed building B15609: rP037c749ef332: Fix missing setQuoteRef() on Commit detail pages in Diffusion.Feb 13 2017, 3:45 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

rP037c749ef332

View Options

src/applications/diffusion/controller/DiffusionCommitController.php