HomePhabricator

Use better variable names

Description

Use better variable names

Summary:
Use p and c instead of (reusing) k. This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/projects/behavior-project-boards.js:

   Warning  (W004) JSHintW004
    'k' is already defined.

              57       'phui-tag-shade-blue': (sum > 0 && !over_limit),
              58       'phui-tag-shade-red': (over_limit)
              59     };
    >>>       60     for (var k in color_map) {
              61       JX.DOM.alterClass(data.countTagNode, k, !!color_map[k]);
              62     }
              63   }

Test Plan: arc lint

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11066

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on Dec 30 2014, 10:56 AM
epriestleyPushed on Dec 30 2014, 10:56 AM
Reviewer
Blessed Reviewers
Differential Revision
D11066: Use better variable names
Parents
rP5251f08fb432: Use `window.confirm` instead of `confirm`
Branches
Unknown
Tags
Unknown