HomePhabricator

Add a common password blacklist

Description

Add a common password blacklist

Summary:
Fixes T4143. This mitigates the "use a botnet to slowly try to login to every user account using the passwords '1234', 'password', 'asdfasdf', ..." attack, like the one that hit GitHub.

(I also donated some money to Openwall as a thanks for compiling this wordlist.)

Test Plan:

  • Tried to register with a weak password; registered with a strong password.
  • Tried to set VCS password to a weak password; set VCS password to a strong password.
  • Tried to change password to a weak password; changed password to a strong password.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, chad

Maniphest Tasks: T4143

Differential Revision: https://secure.phabricator.com/D8048

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jan 23 2014, 10:01 PM
Reviewer
btrahan
Differential Revision
D8048: Add a common password blacklist
Parents
rP1a964f71bb0d: Disable SimpleXML entity loader in Phabricator
Branches
Unknown
Tags
Unknown
Tasks
T4143: Add a common password blacklist

Event Timeline