Page MenuHomePhabricator

Add a common password blacklist
Closed, ResolvedPublic

Description

We currently require 8-character passwords by default, but should also add a default blacklist for "password", "phabricator", etc.

  1. Find some reasonable list(s) of common passwords.
  2. Put them in a file somewhere.
  3. Add anything we can think of that's Phabricator-related ("phabricator", "codereview").
  4. Add an default-on option to reject passwords on the blacklist. Or just do it without an option, I can't really imagine anyone wanting to turn this off.

Context: http://www.theverge.com/2013/11/20/5126906/weak-github-passwords-lead-to-account-security-breach

Revisions and Commits

Event Timeline

epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Security.
epriestley added subscribers: epriestley, chad, btrahan.

@Korvin found this page for the John the Ripper wordlists:

http://www.openwall.com/wordlists/

The short/free one looks perfect; I emailed the donations address to see if we can donate to support it. It's open, but has some quasi-commercial trappings and it feels like we're getting more pure value out of this than other sorts of externals.