HomePhabricator

Add a numeric input control for TOTP codes

Description

Add a numeric input control for TOTP codes

Summary:
Fixes T11365. I tested these variants:

  • <input type="number" />
  • <input type="text" pattern="\d*" />

Of these, this one (using pattern) appears to have the best behavior: it shows the correct keyboard on iOS mobile and does nothing on desktops.

Using type="number" causes unwanted sub-controls to appear in desktop Safari, and a numbers + symbols keyboard to appear on iOS (presumably so users can type "." and "-" and maybe ",").

Test Plan: Tested variants in desktop browsers and iOS simulator, see here and T11365 for discussion.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11365

Differential Revision: https://secure.phabricator.com/D16323

Details

Provenance
epriestleyAuthored on Jul 23 2016, 8:28 PM
epriestleyPushed on Jul 24 2016, 4:13 AM
Reviewer
chad
Differential Revision
D16323: Add a numeric input control for TOTP codes
Parents
rPb6bf0f6a3b49: Re-implement calendar.invite transactions
Branches
Unknown
Tags
Unknown
Tasks
T11365: TOTP challenge entry not marked numeric-only on mobile
Build Status
Buildable 13126
Build 16792: Run Core Tests