Page MenuHomePhabricator

Add a numeric input control for TOTP codes
ClosedPublic

Authored by epriestley on Jul 23 2016, 8:30 PM.
Tags
None
Referenced Files
F15564729: D16323.id39248.diff
Wed, Apr 30, 2:00 PM
F15556864: D16323.id.diff
Mon, Apr 28, 6:46 PM
F15549791: D16323.diff
Sun, Apr 27, 7:48 AM
F15542807: D16323.id.diff
Fri, Apr 25, 7:02 PM
F15498561: D16323.diff
Sun, Apr 13, 1:17 PM
F15434871: D16323.id39248.diff
Mar 25 2025, 5:47 AM
Unknown Object (File)
Feb 16 2025, 7:09 AM
Unknown Object (File)
Feb 9 2025, 2:03 AM
Subscribers
None

Details

Summary

Fixes T11365. I tested these variants:

  • <input type="number" />
  • <input type="text" pattern="\d*" />

Of these, this one (using pattern) appears to have the best behavior: it shows the correct keyboard on iOS mobile and does nothing on desktops.

Using type="number" causes unwanted sub-controls to appear in desktop Safari, and a numbers + symbols keyboard to appear on iOS (presumably so users can type "." and "-" and maybe ",").

Test Plan

Tested variants in desktop browsers and iOS simulator, see here and T11365 for discussion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a numeric input control for TOTP codes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2016, 10:37 PM
This revision was automatically updated to reflect the committed changes.